Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiingo add IEX Historical Reader #619

Merged
merged 4 commits into from Mar 13, 2019

Conversation

@boingaon
Copy link
Contributor

boingaon commented Feb 16, 2019

…storical data in excess of IEx's default time frame.

  • [ x] closes #xxxx
  • [ x] tests added / passed
  • [ x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ x] added entry to docs/source/whatsnew/vLATEST.txt
@addisonlynch

This comment has been minimized.

Copy link
Contributor

addisonlynch commented Feb 17, 2019

I'm not sure if this reader is needed. PDR already provides a reader for IEX historical data (https://pydata.github.io/pandas-datareader/stable/remote_data.html#iex). Unless there is additional functionality here that is not available directly from the provider (IEX), then I think that we don't need to introduce a duplicate

@boingaon

This comment has been minimized.

Copy link
Contributor Author

boingaon commented Feb 28, 2019

Hi. The reason I'm proposing it is that the Tiingo API goes back much farther (2017) with the IEX minute data. IEX native only goes back a trailing 30 days, and you can only select one day at a time.

https://api.tiingo.com/iex/AAPL/prices?startDate=2017-04-01&endDate=2017-04-15&resampleFreq=1min

vs

https://api.iextrading.com/1.0/stock/aapl/chart/1d

@bashtage bashtage merged commit 4ff9a3e into pydata:master Mar 13, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.