Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: Migrate IEX Daily Reader to IEX Cloud #638

Merged
merged 2 commits into from Jun 16, 2019

Conversation

@addisonlynch
Copy link
Contributor

addisonlynch commented May 29, 2019

As discussed in #623, IEX is migrating to a new platform, IEX Cloud on June 1, 2019. At this time, support for the legacy API (existing source for PDR's IEX readers) will end.

This PR migrates IEXDailyReader to IEX Cloud. Additional work to follow will migrate the remainder of the readers.

IEX provides a sandbox environment, which must be enabled by setting IEX_SANDBOX to enable to run tests. A test API key must be used (from IEX Cloud console).

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • added entry to docs/source/whatsnew/vLATEST.txt
@addisonlynch

This comment has been minimized.

Copy link
Contributor Author

addisonlynch commented May 29, 2019

@bashtage will probably want to cut a release for this. Seems to be one of the higher-usage readers and will break when the legacy platform is continued on 6/1. I'll see if I can migrate the rest of the readers before then.

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented May 29, 2019

Any idea what is actually broken? And is it fixable or does it need immediate deprecation

@addisonlynch

This comment has been minimized.

Copy link
Contributor Author

addisonlynch commented May 29, 2019

IEX is migrating off of their legacy API (a free, no auth service) to IEX Cloud which requires auth. URL changes but functionality is the same. This reader will break on 6/1...don't see a need to deprecate and create a new one and add auth. Adding auth to this reader should be fine with a few other smaller modifications. I realized I need to clean up one small caveat with the test suite here then will be good to go.

@addisonlynch

This comment has been minimized.

Copy link
Contributor Author

addisonlynch commented Jun 16, 2019

@bashtage can you review & merge? IEX readers are now dead from provider as is

@bashtage bashtage merged commit b1b54d6 into pydata:master Jun 16, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jzstoller

This comment has been minimized.

Copy link

jzstoller commented Jun 25, 2019

Any idea when this might be fixed? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.