Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit data use #649

Merged
merged 8 commits into from Aug 29, 2019

Conversation

@oceanapplications
Copy link
Contributor

oceanapplications commented Jul 2, 2019

Currently the minimum requested data is a full year. This limits the request to more specific time frames.

The current functionality is undesirable because IEX is no longer unlimited. After this change, for less than 6 days, the cost is 50 messages. Before it was over 3,000.

  • tests added / passed
Currently the minimum requested data is a full year.  This limits the request to more specific time frames.

The current functionality is undesirable because IEX is no longer unlimited.  After this change, for less than 6 days,  the cost is 50 messages.  Before it was over 3,000.
@addisonlynch

This comment has been minimized.

Copy link
Contributor

addisonlynch commented Aug 27, 2019

@bashtage ready

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Aug 27, 2019

Needs a test.

@addisonlynch

This comment has been minimized.

Copy link
Contributor

addisonlynch commented Aug 27, 2019

Hard to test this because the method is private and end results are the same (only effect is message weighting behind the scenes)

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Aug 27, 2019

It is fine to directly test private functions internally. Private doesn't mean private to pdr, only the everything else.

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Aug 27, 2019

In particular all of the new paths need to be visited.

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Aug 27, 2019

Need to get some coverage reporter attached

@addisonlynch

This comment has been minimized.

Copy link
Contributor

addisonlynch commented Aug 27, 2019

Can add coverage to CI

Added Tests
@bashtage bashtage merged commit 9a75c96 into pydata:master Aug 29, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Aug 29, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.