Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/TST: Adjust Alphavantage time series reader to account for descending ordering #666

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@addisonlynch
Copy link
Contributor

addisonlynch commented Aug 28, 2019

Per #662, Alphavantage now returns descending time series data. This PR reconciles this change with PDR and reverses the index to maintain ascending order as is standard. Ensures tests are passing.

  • closes #662
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • added entry to docs/source/whatsnew/vLATEST.txt
@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Aug 29, 2019

Untestable, at least on travis, so lets hope for the best.

@bashtage bashtage merged commit 17366fc into pydata:master Aug 29, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.