Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making minor changes to eurostat and econdb #669

Merged
merged 3 commits into from Sep 14, 2019

Conversation

@simongarisch
Copy link
Contributor

simongarisch commented Sep 7, 2019

The eurostat tests should now be passing: the url had to be changed slightly and a column renamed.

Moving on to econdb, the test urls appear to be returning blank data: e.g.
https://www.econdb.com/api/series/?ticker=BLS_CU.CUSR0000SA0.M.US&format=json&page_size=500&expand=meta

@econdb would you mind confirming what has changed with the API when you have a moment.

Thanks,
Simon.

simongarisch added 3 commits Sep 6, 2019
catchup
@econdb

This comment has been minimized.

Copy link
Contributor

econdb commented Sep 9, 2019

Hi @simongarisch,
thanks for warning us of that bug. Please, have a look at this PR #670 which hopefully sorts the matter.
Cheers

@simongarisch

This comment has been minimized.

Copy link
Contributor Author

simongarisch commented Sep 9, 2019

@econdb Awesome, thanks for that.

@gliptak

This comment has been minimized.

Copy link
Contributor

gliptak commented Sep 14, 2019

@addisonlynch @bashtage please review

This makes Eurostat green https://travis-ci.org/pydata/pandas-datareader/jobs/581966199

pandas_datareader/tests/test_eurostat.py ....
@bashtage bashtage merged commit 1ec9066 into pydata:master Sep 14, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-10.9%) to 73.378%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.