Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when response.encoding is None #674

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@sandrinr
Copy link
Contributor

sandrinr commented Sep 13, 2019

In some rare situations the response provided by Requests does not provide an encoding for the response content (most probably because there is no content). In these cases the retry code of pandas-datareader fails do the assumption the encoding being present at all times.

This mini PR fixes this issue.

@bashtage bashtage merged commit a580d1b into pydata:master Sep 13, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@sandrinr sandrinr deleted the sandrinr:fix-get-response branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.