Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quarter value handling for JSDMX / OECD (+ test) #685

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@gliptak
Copy link
Contributor

gliptak commented Sep 17, 2019

Signed-off-by: Gábor Lipták gliptak@gmail.com

#590
#585

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #685 into master will decrease coverage by 28.98%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #685       +/-   ##
===========================================
- Coverage   83.53%   54.55%   -28.99%     
===========================================
  Files          61       61               
  Lines        2697     2711       +14     
  Branches      303      305        +2     
===========================================
- Hits         2253     1479      -774     
- Misses        366     1166      +800     
+ Partials       78       66       -12
Impacted Files Coverage Δ
pandas_datareader/io/jsdmx.py 91.78% <100%> (-1.97%) ⬇️
pandas_datareader/tests/io/test_jsdmx.py 100% <100%> (ø) ⬆️
pandas_datareader/iex/ref.py 0% <0%> (-100%) ⬇️
pandas_datareader/iex/stats.py 0% <0%> (-86.57%) ⬇️
pandas_datareader/tests/test_wb.py 15.32% <0%> (-77.38%) ⬇️
pandas_datareader/wb.py 15.86% <0%> (-73.11%) ⬇️
pandas_datareader/av/forex.py 22.72% <0%> (-72.73%) ⬇️
pandas_datareader/tests/av/test_av_time_series.py 29.21% <0%> (-70.79%) ⬇️
pandas_datareader/tiingo.py 28.72% <0%> (-67.03%) ⬇️
pandas_datareader/tests/test_tiingo.py 36.17% <0%> (-63.83%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c86c94...a3b2418. Read the comment docs.

@bashtage

This comment has been minimized.

Copy link
Contributor

bashtage commented Sep 17, 2019

Thanks.

@bashtage bashtage merged commit 401bab9 into pydata:master Sep 17, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-27.5%) to 58.988%
Details
codecov/patch 100% of diff hit (target 83.53%)
Details
codecov/project Absolute coverage decreased by -28.98% but relative coverage increased by +16.46% compared to 4c86c94
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bashtage bashtage mentioned this pull request Sep 17, 2019
1 of 4 tasks complete
@gliptak gliptak deleted the gliptak:jsdmx1 branch Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.