Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deprecate access_key #693

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@bashtage
Copy link
Contributor

bashtage commented Sep 18, 2019

Use a decorator to deprecate access_key

closes #692

  • closes #692
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check pandas_datareader
Use a decorator to deprecate access_key

closes #692
@bashtage bashtage force-pushed the bashtage:deprecate-access branch from a197dee to 7735132 Sep 18, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #693 into master will decrease coverage by 13.19%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   83.41%   70.22%   -13.2%     
==========================================
  Files          61       61              
  Lines        2702     2704       +2     
  Branches      301      301              
==========================================
- Hits         2254     1899     -355     
- Misses        372      730     +358     
+ Partials       76       75       -1
Impacted Files Coverage Δ
pandas_datareader/tests/test_quandl.py 42.59% <ø> (-57.41%) ⬇️
pandas_datareader/tests/test_enigma.py 51.61% <0%> (-41.94%) ⬇️
pandas_datareader/data.py 61.63% <66.66%> (-14.8%) ⬇️
pandas_datareader/av/forex.py 22.72% <0%> (-72.73%) ⬇️
pandas_datareader/tests/av/test_av_time_series.py 28.4% <0%> (-71.6%) ⬇️
pandas_datareader/av/quotes.py 26.47% <0%> (-64.71%) ⬇️
pandas_datareader/quandl.py 29.26% <0%> (-63.42%) ⬇️
pandas_datareader/av/time_series.py 31.25% <0%> (-62.5%) ⬇️
pandas_datareader/enigma.py 23.63% <0%> (-60%) ⬇️
pandas_datareader/tiingo.py 38.29% <0%> (-57.45%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f924834...7735132. Read the comment docs.

@bashtage bashtage merged commit f78ea2e into pydata:master Sep 18, 2019
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 40% of diff hit (target 83.41%)
Details
codecov/project 70.22% (-13.2%) compared to f924834
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-3.4%) to 65.998%
Details
@bashtage bashtage deleted the bashtage:deprecate-access branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.