Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add python 3.7 testing #140

Merged
merged 5 commits into from Oct 31, 2018
Merged

TST: Add python 3.7 testing #140

merged 5 commits into from Oct 31, 2018

Conversation

thequackdaddy
Copy link
Contributor

I think this will get python 3.7 testing on patsy

@codecov-io
Copy link

codecov-io commented Oct 29, 2018

Codecov Report

Merging #140 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   98.96%   98.96%   +<.01%     
==========================================
  Files          30       30              
  Lines        5582     5585       +3     
  Branches      775      775              
==========================================
+ Hits         5524     5527       +3     
  Misses         35       35              
  Partials       23       23
Impacted Files Coverage Δ
patsy/constraint.py 98.01% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e141c8a...1869503. Read the comment docs.

@thequackdaddy
Copy link
Contributor Author

I also added a try ... except around the import collections.abc from Mapping as that got moved.

tools/check-API-refs.py Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@njsmith
Copy link
Member

njsmith commented Oct 30, 2018

Apparently I misremembered the syntax, and language: none actually means "ruby". The actual no-language images are minimal and generic: https://docs.travis-ci.com/user/languages/minimal-and-generic/

I just tried switching it to minimal, let's see what Travis does...

@njsmith njsmith merged commit 4c613d0 into pydata:master Oct 31, 2018
@thequackdaddy thequackdaddy deleted the py37 branch October 31, 2018 21:56
@astrojuanlu
Copy link

Any chance to release these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants