Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding support for saving matrices to files in npz format #154
@@ Coverage Diff @@ ## master #154 +/- ## ========================================== + Coverage 96.89% 96.93% +0.04% ========================================== Files 10 11 +1 Lines 1191 1207 +16 ========================================== + Hits 1154 1170 +16 Misses 37 37
Overall, this is an awesome effort. We strive for perfection, so you can make changes and I'll approve.
One thing not in this review is that you should add
save_npz into the list of functions in
docs/generated/sparse.rst before building the docs.
Looks like most of the major concerns have been addressed, here are some other recommendations. Good work by the way.
A few more changes.
We want the user-facing API to be compatible with
scipy.sparse, so the
.io should be removed everywhere and it should just be treated as an internal submodule.
May 20, 2018
thank you! pleasure working with you…
On Sun, May 20, 2018, 16:45 Hameer Abbasi ***@***.***> wrote: This is in! Thanks, @nimroha <https://github.com/nimroha>! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APXkV-ORzdvI59Af740eEnn13VHn_BeNks5t0XOKgaJpZM4UDK5E> .