Join GitHub today
Initial implementation for arbitrary fill values. #165
@@ Coverage Diff @@ ## master #165 +/- ## ========================================== + Coverage 96.96% 97.12% +0.15% ========================================== Files 11 11 Lines 1219 1252 +33 ========================================== + Hits 1182 1216 +34 + Misses 37 36 -1
I have a few minor comments, but I'm excited about this! The implementation looks quite clean.
This will let us define functions all the nan-aggregations (e.g.,
nanmedian()) for use in xarray. These functions can simply require a fill value of NaN.
Just another minor comment. I agree that this looks good to merge!
I appreciate getting pinged, but I probably won't be reviewing this one. That's also fine. I probably shouldn't be active on every pull request here. It looks like @shoyer seems pretty happy, which is a good sign. I trust his attention to detail :)