New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fill-value on conversion from NumPy. #180

Merged
merged 2 commits into from Sep 6, 2018

Conversation

Projects
None yet
1 participant
@hameerabbasi
Collaborator

hameerabbasi commented Sep 6, 2018

Allows specifying a fill-value when converting from a NumPy array.

@codecov

This comment has been minimized.

codecov bot commented Sep 6, 2018

Codecov Report

Merging #180 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #180      +/-   ##
=========================================
+ Coverage   96.91%   97.3%   +0.39%     
=========================================
  Files          11      11              
  Lines        1295    1301       +6     
=========================================
+ Hits         1255    1266      +11     
+ Misses         40      35       -5
Impacted Files Coverage Δ
sparse/coo/core.py 96.78% <100%> (+0.04%) ⬆️
sparse/sparse_array.py 96.66% <100%> (+3.56%) ⬆️
sparse/compatibility.py 83.33% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916df6f...6ccd619. Read the comment docs.

@hameerabbasi hameerabbasi merged commit b03b6b9 into pydata:master Sep 6, 2018

5 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.91%)
Details
codecov/project 97.3% (+0.39%) compared to 916df6f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hameerabbasi hameerabbasi deleted the hameerabbasi:convert-fill-value branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment