Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd eye, zeros, zeros_like, ones, ones_like #183
Conversation
jcrist
added some commits
Sep 17, 2018
jcrist
force-pushed the
jcrist:creation-functions
branch
from
5beb33c
to
ff67350
Sep 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Looks like docstrings need to be spaced slightly differently. Maybe a difference in Numpy version? |
This comment has been minimized.
This comment has been minimized.
|
Grumble. Since Seems to be only an issue with float arrays, just skipped those tests. |
This comment has been minimized.
This comment has been minimized.
rgommers
commented
Sep 17, 2018
|
The normal approach is to only run doctests for the latest version of numpy. With all the print changes around numpy 1.14, that's the only reasonable thing to do in CI. |
This comment has been minimized.
This comment has been minimized.
|
That's what we do in dask/dask. This is probably Hameer's call though.
…On Mon, Sep 17, 2018 at 5:06 PM Ralf Gommers ***@***.***> wrote:
The normal approach is to only run doctests for the latest version of
numpy. With all the print changes around numpy 1.14, that's the only
reasonable thing to do in CI.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#183 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszOcw813s1wbIb1umDB9WPxWt4E_6ks5ucA66gaJpZM4WsrO6>
.
|
hameerabbasi
approved these changes
Sep 17, 2018
This looks generally complete and in excellent shape. I’ve made a few comments that should increase performance generally.
Also it might be nice to have ones_like with fill values.
If you want more visibility for your work (wink wink) a line in the change log would be nice.
| coords = np.stack([n_coords, m_coords]) | ||
| data = np.ones(data_length, dtype=dtype) | ||
| return COO(coords, data=data, shape=(N, M), has_duplicates=False) |
This comment has been minimized.
This comment has been minimized.
| shape = (shape,) | ||
| data = np.empty(0, dtype=dtype) | ||
| coords = np.empty((len(shape), 0), dtype=np.intp) | ||
| return COO(coords, data=data, shape=shape, has_duplicates=False) |
This comment has been minimized.
This comment has been minimized.
| >>> zeros_like(x).todense() # doctest: +NORMALIZE_WHITESPACE | ||
| array([[0, 0, 0], | ||
| [0, 0, 0]]) | ||
| """ |
This comment has been minimized.
This comment has been minimized.
| n_coords = m_coords = np.arange(data_length, dtype=np.intp) | ||
| coords = np.stack([n_coords, m_coords]) | ||
| data = np.ones(data_length, dtype=dtype) |
This comment has been minimized.
This comment has been minimized.
hameerabbasi
Sep 17, 2018
Collaborator
Data as a scalar should work here. Takes less memory due to scalar broadcasting being a view.
This comment has been minimized.
This comment has been minimized.
|
Re the printing changes, yes, since we are highly likely to need changes in upcoming NumPy versions, it’s nice to have them with the newer versions. This has been a pain point in a PR or two, but I think being on old NumPy docstrings would be worse. |
jcrist
changed the title from
Add eye, zeros, zeros_like
to
Add eye, zeros, zeros_like, ones, ones_like
Sep 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review, I believe all comments have been addressed. |
jcrist
force-pushed the
jcrist:creation-functions
branch
from
8db1e2f
to
512ed57
Sep 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Thabks for making these changes! They’re very welcome. Merging now. |
jcrist commentedSep 17, 2018
Add implementations of
eye,zeros, andzeros_like, mirroring the equivalent numpy api.