Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add eye, zeros, zeros_like, ones, ones_like #183
Seems to be only an issue with float arrays, just skipped those tests.
That's what we do in dask/dask. This is probably Hameer's call though.…
On Mon, Sep 17, 2018 at 5:06 PM Ralf Gommers ***@***.***> wrote: The normal approach is to only run doctests for the latest version of numpy. With all the print changes around numpy 1.14, that's the only reasonable thing to do in CI. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszOcw813s1wbIb1umDB9WPxWt4E_6ks5ucA66gaJpZM4WsrO6> .
This looks generally complete and in excellent shape. I’ve made a few comments that should increase performance generally.
Also it might be nice to have
ones_like with fill values.
If you want more visibility for your work (wink wink) a line in the change log would be nice.
Re the printing changes, yes, since we are highly likely to need changes in upcoming NumPy versions, it’s nice to have them with the newer versions.
This has been a pain point in a PR or two, but I think being on old NumPy docstrings would be worse.