Add order parameter to COO.reshape

[jcrist]

Adds support for np.reshape to dispatch to COO.reshape properly.

[codecov]

Codecov Report

Merging #193 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   97.52%   97.52%   +<.01%     
==========================================
  Files          11       11              
  Lines        1416     1417       +1     
==========================================
+ Hits         1381     1382       +1     
  Misses         35       35

Impacted Files	Coverage Δ
sparse/coo/core.py	97.09% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21b027...3daf0a6. Read the comment docs.

[hameerabbasi]

One minor change.

[hameerabbasi]

We might want to remove these two lines from the test, if we add this functionality later it'll crap out.

[hameerabbasi]

An exception from coverage is already in place.

[jcrist]

Done.

I personally prefer to check these errors - in the past I've seen code that was supposed to raise a DeprecationWarning or NotImplementedError fail to actually raise due to a bug. I don't think of the tests as the-one-uneditable-source-of-truth, I think someone adding this functionality wouldn't be surprised to see a test fail due to a NotImplementedError not being raised anymore, and be fine changing the test.

Anyway, happy to cede to you here. I believe this should be good to go.

[hameerabbasi]

Fair enough. 👍