Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add sparse.kron #194
@@ Coverage Diff @@ ## master #194 +/- ## ========================================== + Coverage 97.52% 97.57% +0.04% ========================================== Files 11 11 Lines 1417 1444 +27 ========================================== + Hits 1382 1409 +27 Misses 35 35
If this is really urgent, go ahead and merge it after these changes. I'm working on a version of
kron using that will work on arbitrary dimensionality, and that one will supersede this one.
If you can wait a day or two, I'll put my PR in.
Glad to hear it! I figured there'd be a more efficient/elegant way to express this in ndimensions, but my immediate need was for a 2 dimensions only and using the scipy sparse implementation was easy. I look forward to seeing your implementation.
I believe all concerns have been addressed. Thanks for the review, merging.