Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd COO.imag, COO.real, COO.conj() #196
Conversation
jcrist
force-pushed the
jcrist:add-complex-methods
branch
from
313c28d
to
4f77ce4
Oct 2, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Oct 2, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 97.64% 97.65% +<.01%
==========================================
Files 11 11
Lines 1441 1447 +6
==========================================
+ Hits 1407 1413 +6
Misses 34 34
Continue to review full report at Codecov.
|
hameerabbasi
requested changes
Oct 3, 2018
•
I'm not entirely sure if a Returns section would be appropriate in the docstring... Other than that, these comments are all I have.
Feel free to merge after these and a changelog entry.
This comment has been minimized.
This comment has been minimized.
|
I believe I've resolved all issues. Thanks for the review, merging. |
jcrist
merged commit d9b9e2a
into
pydata:master
Oct 5, 2018
jcrist
deleted the
jcrist:add-complex-methods
branch
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jcrist commentedOct 2, 2018
Add methods and properties to support complext sparse arrays, matching the numpy api.