New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COO.imag, COO.real, COO.conj() #196

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@jcrist
Collaborator

jcrist commented Oct 2, 2018

Add methods and properties to support complext sparse arrays, matching the numpy api.

Add COO.imag, COO.real, COO.conj()
Add methods and properties to support complext sparse arrays, matching
the numpy api.

@jcrist jcrist force-pushed the jcrist:add-complex-methods branch from 313c28d to 4f77ce4 Oct 2, 2018

@codecov

This comment has been minimized.

codecov bot commented Oct 2, 2018

Codecov Report

Merging #196 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   97.64%   97.65%   +<.01%     
==========================================
  Files          11       11              
  Lines        1441     1447       +6     
==========================================
+ Hits         1407     1413       +6     
  Misses         34       34
Impacted Files Coverage Δ
sparse/coo/core.py 97.14% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81eccee...a771d04. Read the comment docs.

@hameerabbasi

hameerabbasi requested changes Oct 3, 2018 edited

I'm not entirely sure if a Returns section would be appropriate in the docstring... Other than that, these comments are all I have.

Feel free to merge after these and a changelog entry.

Show resolved Hide resolved sparse/coo/core.py
Show resolved Hide resolved sparse/coo/core.py
Show resolved Hide resolved sparse/coo/core.py
Show resolved Hide resolved sparse/tests/test_coo.py
@jcrist

This comment has been minimized.

Collaborator

jcrist commented Oct 5, 2018

I believe I've resolved all issues. Thanks for the review, merging.

@jcrist jcrist merged commit d9b9e2a into pydata:master Oct 5, 2018

5 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.64%)
Details
codecov/project 97.65% (+<.01%) compared to 81eccee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcrist jcrist deleted the jcrist:add-complex-methods branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment