Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COO.imag, COO.real, COO.conj() #196

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Conversation

jcrist
Copy link
Collaborator

@jcrist jcrist commented Oct 2, 2018

Add methods and properties to support complext sparse arrays, matching the numpy api.

Add methods and properties to support complext sparse arrays, matching
the numpy api.
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #196 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   97.64%   97.65%   +<.01%     
==========================================
  Files          11       11              
  Lines        1441     1447       +6     
==========================================
+ Hits         1407     1413       +6     
  Misses         34       34
Impacted Files Coverage Δ
sparse/coo/core.py 97.14% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81eccee...a771d04. Read the comment docs.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if a Returns section would be appropriate in the docstring... Other than that, these comments are all I have.

Feel free to merge after these and a changelog entry.

sparse/coo/core.py Show resolved Hide resolved
sparse/coo/core.py Show resolved Hide resolved
sparse/coo/core.py Show resolved Hide resolved
sparse/tests/test_coo.py Show resolved Hide resolved
@jcrist
Copy link
Collaborator Author

jcrist commented Oct 5, 2018

I believe I've resolved all issues. Thanks for the review, merging.

@jcrist jcrist merged commit d9b9e2a into pydata:master Oct 5, 2018
@jcrist jcrist deleted the add-complex-methods branch October 5, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants