New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype not being preserved with the out kwarg. #206

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
1 participant
@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Nov 11, 2018

Fix #205

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 11, 2018

Codecov Report

Merging #206 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   97.63%   97.66%   +0.02%     
==========================================
  Files          11       11              
  Lines        1483     1501      +18     
==========================================
+ Hits         1448     1466      +18     
  Misses         35       35
Impacted Files Coverage Δ
sparse/coo/umath.py 97.13% <100%> (+0.2%) ⬆️
sparse/coo/core.py 97.15% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5333d7c...1402215. Read the comment docs.

@hameerabbasi hameerabbasi merged commit da7a64d into pydata:master Nov 11, 2018

5 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.63%)
Details
codecov/project 97.66% (+0.02%) compared to 5333d7c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hameerabbasi hameerabbasi deleted the hameerabbasi:fix-inpace-dtype branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment