New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow in reduce. #208

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Nov 12, 2018

Fixes #207

@hameerabbasi hameerabbasi referenced this pull request Nov 12, 2018

Closed

Overflow on reshape #207

@hameerabbasi

This comment has been minimized.

Copy link
Collaborator

hameerabbasi commented Nov 12, 2018

@mrocklin Reaching out to you for advice, any way to fix and/or ignore the Python 2 doctests?

@mrocklin

This comment has been minimized.

Copy link
Collaborator

mrocklin commented Nov 12, 2018

Hi @hameerabbasi . My recommendation would be to just not test doctests in Python 2 and be done with it

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #208 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   97.66%   97.66%   +<.01%     
==========================================
  Files          11       11              
  Lines        1501     1502       +1     
==========================================
+ Hits         1466     1467       +1     
  Misses         35       35
Impacted Files Coverage Δ
sparse/coo/core.py 97.15% <100%> (ø) ⬆️
sparse/compatibility.py 83.33% <100%> (ø) ⬆️
sparse/sparse_array.py 96.77% <100%> (+0.1%) ⬆️
sparse/coo/common.py 97.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7a64d...1a7b2d6. Read the comment docs.

@hameerabbasi hameerabbasi merged commit c1a2bfa into pydata:master Nov 13, 2018

5 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.66%)
Details
codecov/project 97.66% (+<.01%) compared to da7a64d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment