@@ Coverage Diff @@ ## master #210 +/- ## ========================================== + Coverage 97.66% 97.67% +<.01% ========================================== Files 11 11 Lines 1502 1505 +3 ========================================== + Hits 1467 1470 +3 Misses 35 35
hameerabbasi merged commit
Nov 19, 2018
5 checks passed
Someone pulled out Dask's config system into a separate package. https://github.com/pytroll/donfig If we need more configuration in the future it might be worth considering. https://docs.dask.org/en/latest/configuration.html…
On Tue, Nov 20, 2018 at 4:47 AM Hameer Abbasi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In sparse/__init__.py <#210 (comment)>: > @@ -7,3 +7,9 @@ from ._version import get_versions __version__ = get_versions()['version'] del get_versions + +import os + +_AUTO_DENSIFICATION_ENABLED = bool(int(os.environ.get('SPARSE_AUTO_DENSIFY', '1'))) + The problem is that that isn't thread safe. For example, if you do it with Dask or whatever else, it can blow stuff up. An environment variable loaded at import time is guaranteed to be thread safe. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#210 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszDT6fLc_pylLqjFvzbekjyPyGiUJks5uw8-WgaJpZM4Yp7CW> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.