/sparse

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow auto-densification. #220

Merged
merged 2 commits into from Dec 13, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hameerabbasi @scopatz
@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Dec 13, 2018

Fixes #218
@hameerabbasi
Disallow auto-densification.
Loading status checks…
a92d2ac

@hameerabbasi hameerabbasi referenced this pull request Dec 13, 2018

Closed

Disallow np.array(COO) #218

@hameerabbasi
Fix CI for older NumPy versions.
Loading status checks…
cf549c5
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Dec 13, 2018 •
edited

Codecov Report

Merging #220 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   97.59%   97.59%   +<.01%     
==========================================
  Files          11       11              
  Lines        1539     1541       +2     
==========================================
+ Hits         1502     1504       +2     
  Misses         37       37
Impacted Files Coverage Δ
sparse/coo/core.py 96.66% <ø> (-0.05%) ⬇️
sparse/sparse_array.py 97.36% <100%> (+0.59%) ⬆️
sparse/coo/common.py 98.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46a2a7...cf549c5. Read the comment docs.
@scopatz

This comment has been minimized.

Sign in to view
Copy link

scopatz commented Dec 13, 2018

LGTM! Thanks @hameerabbasi!

@hameerabbasi hameerabbasi merged commit 17473e2 into pydata:master Dec 13, 2018
5 checks passed

5 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.59%)
Details
codecov/project 97.59% (+<.01%) compared to e46a2a7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hameerabbasi hameerabbasi deleted the hameerabbasi:disable-auto-densify branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment