Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nnz for scalars. #48

Merged
merged 1 commit into from Dec 27, 2017
Merged

Fix nnz for scalars. #48

merged 1 commit into from Dec 27, 2017

Conversation

@hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Dec 27, 2017

Addresses #47.

@mrocklin
Copy link
Collaborator

@mrocklin mrocklin commented Dec 27, 2017

Is there a test that should have failed previously to this change? Can we add such a test to prevent regressions in the future?

@hameerabbasi
Copy link
Collaborator Author

@hameerabbasi hameerabbasi commented Dec 27, 2017

I am hesitant to add a test (although I can add one) because indexing scalars in the future may give us scalars rather than COO objects. That's the way numpy/scipy.sparse do it, and that's how I believe it should be done. However, x[1, 1, ...] should give us a COO object for 2-D x.

@mrocklin
Copy link
Collaborator

@mrocklin mrocklin commented Dec 27, 2017

OK. +1 from me then

@hameerabbasi hameerabbasi merged commit 23c8d88 into pydata:master Dec 27, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hameerabbasi hameerabbasi deleted the hameerabbasi:fix-scalar-nnz branch Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants