New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.4 #1829

Closed
jhamman opened this Issue Jan 15, 2018 · 13 comments

Comments

Projects
None yet
5 participants
@jhamman
Copy link
Member

jhamman commented Jan 15, 2018

Python 3.7-final is due out in June (PEP 537). When do we want to deprecate 3.4 and when should we drop support all together. @maxim-lian brought this up in a PR he's working on: #1828 (comment).

For reference, we dropped Python 3.3 in #1175 (12/20/2016).

@shoyer

This comment has been minimized.

Copy link
Member

shoyer commented Jan 15, 2018

It looks like pandas has already dropped Python 3.4 support in v0.21: pandas-dev/pandas#18763

So I'd be favor of dropping it for xarray too in the next major release.

@jhamman jhamman added this to the 0.11 milestone Jan 15, 2018

@Zac-HD

This comment has been minimized.

Copy link
Contributor

Zac-HD commented Jan 15, 2018

Related: when does Xarray plan to drop Python 2? IMO we should at least join python3statement.org and drop it by 2020, and clearly document the timeline whatever it happens to be.

I'd be keen for an earlier date TBH - keyword-only arguments are great, compatibility shims kinda suck, and dependencies are moving to py3-only at an increasing rate (including matplotlib 3.0, scheduled for July) - but can see the other argument too.

@shoyer

This comment has been minimized.

Copy link
Member

shoyer commented Jan 15, 2018

@Zac-HD see #1830

@jhamman

This comment has been minimized.

Copy link
Member

jhamman commented Jan 31, 2018

Saving the PR until after 0.10 is released but here's commit that drops Python 3.4: 5c96b54

@max-sixty

This comment has been minimized.

Copy link
Collaborator

max-sixty commented Apr 3, 2018

@jhamman shall we do this now? Amazingly this is breaking the flake8 of #2031

@jhamman

This comment has been minimized.

Copy link
Member

jhamman commented Apr 3, 2018

Fine by me. Would we want to make the next version 0.11 then?

@shoyer

This comment has been minimized.

Copy link
Member

shoyer commented Apr 3, 2018

If maintaining Python 3.4 support is a pain, I'm happy to drop it (certainly from our test suite). I would rather save major versions for major revisions to the project, however.

@max-sixty

This comment has been minimized.

Copy link
Collaborator

max-sixty commented Apr 3, 2018

Completely agree re versions, and I can navigate around it; assuming 0.11 is not the next release

@shoyer

This comment has been minimized.

Copy link
Member

shoyer commented Apr 3, 2018

Indeed, my plan is to release 0.10.3 shortly after your isin PR gets in :)

@jhamman

This comment has been minimized.

Copy link
Member

jhamman commented Apr 3, 2018

Apologies for conflating the two issues here. I didn't mean to suggest we should skip straight to 0.11 for the sake of dropping 3.4. More that we should try to time the two together if possible. As @shoyer said, we can drop 3.4 from the test suite if need be.

@djhoese

This comment has been minimized.

Copy link
Contributor

djhoese commented Apr 14, 2018

I just ran in to an issue testing Python 3.4 on Travis where xarray asked for pandas >0.18.0 which pulls in a version of pandas that is not compatible with Python 3.4 (pandas-dev/pandas#20697). It also seems like this could be related to pip 10.0.

I'm ok dropping Python 3.4 from my tests, but is this python version check something pip/pypi should handle or is it something that xarray has to check in its setup.py?

Edit: I should have just made a new issue, sorry.

@shoyer

This comment has been minimized.

Copy link
Member

shoyer commented Apr 14, 2018

Python 3.4 was supported by pandas 0.18, so I'm not sure what's going on here. I don't think it's really an xarray issue.

@djhoese

This comment has been minimized.

Copy link
Contributor

djhoese commented Apr 14, 2018

Looks like it is related to pip 10.0, with pip 9.0.3 it seems to install pandas fine on Python 3.4. I'll continue debugging this with pandas and the pip projects. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment