Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autoclose in open_dataset and related warning test #4725

Merged
merged 5 commits into from Dec 24, 2020
Merged

remove autoclose in open_dataset and related warning test #4725

merged 5 commits into from Dec 24, 2020

Conversation

aurghs
Copy link
Collaborator

@aurghs aurghs commented Dec 23, 2020

This PR remove autoclose option from open_dataset (both api.py and apiv2.py) and the corresponding test test_autoclose_future_warning from test.py
autoclose=True option was deprecated in #2261 since xarray now uses a LRU cache to manage open file handles.

@alexamici
Copy link
Collaborator

alexamici commented Dec 23, 2020

@aurghs there's a conflict, would you please fix it?

@alexamici
Copy link
Collaborator

@aurghs I think you should check what documentation needs updating beside the doctring.

Also this deserves and entry in what's new.

@alexamici
Copy link
Collaborator

I merge as it has been discussed yesterday in the community meeting.

@alexamici alexamici merged commit 1525fb0 into pydata:master Dec 24, 2020
toddrjen pushed a commit to toddrjen/xarray that referenced this pull request Dec 31, 2020
* remove autoclose in open_dataset and related warning test

* black

* remove autoclose from open_mfdataset

* update what's new
@aurghs aurghs deleted the remove_autoclose branch February 11, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants