Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filewriter group length fields #32

Closed
darcymason opened this issue Nov 27, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@darcymason
Copy link
Member

commented Nov 27, 2014

From darcymason@gmail.com on December 10, 2008 22:48:30

It looks like filewriter module does not recalc group length fields except
for file meta info section. Should make this the case for all groups.

Original issue: http://code.google.com/p/pydicom/issues/detail?id=30

@darcymason

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2014

From darcymason@gmail.com on December 17, 2008 16:00:37

Labels: Milestone-Release1.0

@darcymason

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2014

From darcymason@gmail.com on April 08, 2009 05:36:46

Section 7.2 of PS3.5-2008 recommends that group lengths be removed (except group 2
meta info, which is mandatory). Should consider removing them, perhaps use an
optional flag (default is to remove) ... but need to look at "round trip" unit tests
which read and then write test files and binary compare them, to see if this will
break any of those tests.

mrbean-bremen added a commit to mrbean-bremen/pydicom that referenced this issue Mar 10, 2018

Remove Group Length while writing a data set
- as recommended by PS3.5, chapter 7.2
- closes pydicom#32

mrbean-bremen added a commit to mrbean-bremen/pydicom that referenced this issue Mar 10, 2018

Remove Group Length while writing a data set
- as recommended by PS3.5, chapter 7.2
- closes pydicom#32

darcymason added a commit that referenced this issue Mar 15, 2018

Remove Group Length while writing a data set (#595)
- as recommended by PS3.5, chapter 7.2
- closes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.