Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Allows login for deleted users in master/slave setup #38

Closed
debfx opened this issue Mar 20, 2013 · 2 comments
Closed

Allows login for deleted users in master/slave setup #38

debfx opened this issue Mar 20, 2013 · 2 comments

Comments

@debfx
Copy link

debfx commented Mar 20, 2013

When using a master/slave (ldap/serial) setup ajaxplorer allows users to login even after they have been deleted from LDAP.

The users gets a local (= serial) account when he logs in once.
checkPassword() in plugins/auth.multi/class.multiAuthDriver.php checks both drivers so when logging in though the master authentication fails he still can use the slave (= serial) authentication.

My suggestions would be to limit slave authentication in a master/slave setup to special accounts like the default "admin" user and users with the profile "shared" and "guest".
I have a patch for this if you think this is a sane solution.

I am using ajaxplorer 4.3.1.

@cdujeu
Copy link
Member

cdujeu commented Mar 20, 2013

Indeed, that would make sense IMO. Can you submit a pull request? Best would be to have a specific auth.multi parameter that would cover both cases

@debfx
Copy link
Author

debfx commented Mar 20, 2013

I've created a pull request with a solution that tracks if the user has been created by authenticating to the master auth plugin.
This should be a more clean solution as it avoids hardcoding profile or account names that are allowed.

@cdujeu cdujeu closed this as completed Mar 28, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants