Removed the general deprecation warning from System. #262

Merged
merged 1 commit into from Aug 26, 2015

Conversation

Projects
None yet
2 participants
@moorepants
Member

moorepants commented Aug 25, 2015

This was a bad idea. We shouldn't use a deprecation warning unless we are
actually deprecating something in a very specific way.

  • There are no merge conflicts.
  • If there is a related issue, a reference to that issue is in the
    commit message.
  • Unit tests have been added for the bug. (Please reference the issue #
    in the unit test.)
  • The tests pass both locally (run nosetests) and on Travis CI.
  • The code follows PEP8 guidelines. (use a linter, e.g.
    pylint, to check your code)
  • The bug fix is documented in the Release
    Notes
    .
  • The code is backwards compatible. (All public methods/classes must
    follow deprecation cycles.)
  • All reviewer comments have been addressed.
Removed the general deprecation warning from System.
This was a bad idea. We shouldn't use a deprecation warning unless we are
acutally deprecating something in a very specific way.
@moorepants

This comment has been minimized.

Show comment
Hide comment
@moorepants

moorepants Aug 26, 2015

Member

@pydy/pydy-developers Can someone review and merge this? Thanks.

Member

moorepants commented Aug 26, 2015

@pydy/pydy-developers Can someone review and merge this? Thanks.

oliverlee added a commit that referenced this pull request Aug 26, 2015

Merge pull request #262 from moorepants/remove-dumb-warning
Removed the general deprecation warning from System.

@oliverlee oliverlee merged commit df1e7fe into pydy:master Aug 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@moorepants moorepants deleted the moorepants:remove-dumb-warning branch Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment