Skip to content

WORKAROUND: Force usage of pythonX.X for -m venv#245

Closed
seliger wants to merge 2 commits into
pyenv:masterfrom
seliger:master
Closed

WORKAROUND: Force usage of pythonX.X for -m venv#245
seliger wants to merge 2 commits into
pyenv:masterfrom
seliger:master

Conversation

@seliger

@seliger seliger commented Dec 28, 2017

Copy link
Copy Markdown

Uses ${PYENV_VERSION:0:3} to force venv to correctly
make all of the necessary symlinks in the virtualenv's
bin directory.

Refer to issue #206 for details.

Uses ${PYENV_VERSION:0:3} to force venv to correctly
make all of the necessary symlinks in the virtualenv's
bin directory.
While the first commit seemingly produced the intended
results, the changes inadvertantly and unexpected broke
all of the unit tests. This commit represnts changes to
both pyenv-virtualenv and its associated tests to employ
the force pythonX.X workaround.
@DuncanHills

DuncanHills commented Feb 14, 2018

Copy link
Copy Markdown

Can the authors consider this pull request? In addition to the aforementioned use cases (tox), this bug affects using Pants and PEX with pyenv-virtulalenv.

@robertlagrant

robertlagrant commented Oct 8, 2018

Copy link
Copy Markdown

+1

This is a genuine issue for tox users.

@native-api

Copy link
Copy Markdown
Member

This would break for non-CPython; already fixed in #296

@native-api native-api closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants