Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-build: add anaconda[23]-5.3.1 #1246

Merged
merged 2 commits into from Nov 24, 2018

Conversation

Projects
None yet
2 participants
@binbjz
Copy link
Contributor

binbjz commented Nov 24, 2018

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

Tests

  • My PR adds the following unit tests (if any)
ZhaoBin
@@ -0,0 +1,19 @@
case "$(anaconda_architecture 2>/dev/null || true)" in
"Linux-x86" )
install_script "Anaconda2-5.3.1-Linux-x86" "https://repo.continuum.io/archive/Anaconda2-5.3.1-Linux-x86.sh#5685ac1d4a14c4c254cbafc612c77e77" "anaconda" verify_py27

This comment has been minimized.

Copy link
@yyuu

yyuu Nov 24, 2018

Collaborator

Is the checksum a SHA256...? It looks like shorter than expected 🤔

This comment has been minimized.

Copy link
@binbjz

binbjz Nov 24, 2018

Author Contributor

Sorry, I added wrong file. I have updated it.

ZhaoBin
@yyuu

yyuu approved these changes Nov 24, 2018

@yyuu yyuu merged commit dd523b7 into pyenv:master Nov 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.