fix(validator): Forbidden rule does not support float #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyfuture
requested changes
Sep 30, 2018
Member
funkyfuture
left a comment
funkyfuture
left a comment
There was a problem hiding this comment.
there must be at least tests covering the currently undesired behaviour (w/ the intended outcome).
| KEYSRULES = KEYSCHEMA = ErrorDefinition(0x83, 'keysrules') | ||
| VALUESRULES = VALUESCHEMA = ErrorDefinition(0x84, 'valuesrules') | ||
| BAD_ITEMS = ErrorDefinition(0x8f, 'items') | ||
| BAD_ITEMS = ErrorDefinition(0x8F, 'items') |
Member
There was a problem hiding this comment.
that is an unnecessary change.
Author
There was a problem hiding this comment.
this violates black reformatting rule in travis pipeline.
| elif isinstance(value, int): | ||
| if value in forbidden_values: | ||
| self._error(field, errors.FORBIDDEN_VALUE, value) | ||
| elif isinstance(value, float): |
Member
There was a problem hiding this comment.
please keep it simple. afaict, there's no need to branch off for float or integer values, only for container values that are not strings.
funkyfuture
added a commit
to funkyfuture/cerberus
that referenced
this pull request
Nov 24, 2018
funkyfuture
added a commit
to funkyfuture/cerberus
that referenced
this pull request
Nov 24, 2018
Member
|
Closing in favour of #455. |
funkyfuture
added a commit
that referenced
this pull request
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#436