Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility imports of abstract base classes #451

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@funkyfuture
Copy link
Member

commented Oct 3, 2018

No description provided.

@funkyfuture funkyfuture added this to the 1.2.1 milestone Oct 3, 2018

@funkyfuture funkyfuture force-pushed the funkyfuture:abc123 branch 4 times, most recently from 8040b13 to c8b91cc Oct 3, 2018

@adamchainz
Copy link

left a comment

+1 since pytest started surfacing all deprecation warnings at the end of test runs I see this a lot :)

CHANGES.rst Outdated
@@ -40,6 +40,7 @@ Improved

Docs
~~~~
- Fix semantical versioning naming. There are only two hard things in Computer Science: cache invalidation and naming things -- *Phil Karlton* (`#429`_)

This comment has been minimized.

Copy link
@adamchainz

adamchainz Oct 10, 2018

semantic not semantical

@funkyfuture funkyfuture force-pushed the funkyfuture:abc123 branch from c8b91cc to da16545 Oct 10, 2018

nicolaiarocci added a commit that referenced this pull request Oct 20, 2018

@nicolaiarocci

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

rebased and merged

@funkyfuture funkyfuture deleted the funkyfuture:abc123 branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.