New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGO_URI raises exception when no database is specified #1037

Closed
nicolaiarocci opened this Issue Jul 6, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@nicolaiarocci
Member

nicolaiarocci commented Jul 6, 2017

The mongo data layer raises an exception when MONGO_URI does not contain a database name. However, the MongoDB URI syntax states that only the host is required and for good reasons.

In certain scenarios, it might be useful to set the ReplicaSet and other options with the URI, and then set the database dynamically with MONGO_DBNAME, maybe depending on the user performing the request.

The current implementation mimics Flask_PyMongo behavior. However, since we recently dropped that dependency, we are free to improve in this area.

@nicolaiarocci nicolaiarocci self-assigned this Jul 6, 2017

@nicolaiarocci nicolaiarocci added this to the 0.8 milestone Jul 6, 2017

Amedeo91 pushed a commit to Amedeo91/eve that referenced this issue Aug 11, 2017

Amedeo91 pushed a commit to Amedeo91/eve that referenced this issue Aug 11, 2017

Amedeo91 pushed a commit to Amedeo91/eve that referenced this issue Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment