/eve

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider the adoption of Black-style code formatting and tooling #1155

Closed
nicolaiarocci opened this Issue May 28, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.8.1
1 participant
@nicolaiarocci
@nicolaiarocci
Member

nicolaiarocci commented May 28, 2018 •
edited

I like Black.

Two small concerns:

  • Unsure on the 88 chars line-length. Can be trimmed down to 79/80, but it will still leave unbreakable lines (long strings, for example) untouched. Overall I think the 10% rule is good, and I could also live with longer lines when breaking would make them basically unreadable (long strings, again).
  • Landing a successful PR might become more tedious. With version control integration and a small addendum to the contributing instructions, we might make this more manageable. This is probably not a concern since we already run flake8 on CI - we'd only need to tweak it a little bit (flake8-bugbear, etc.)

@nicolaiarocci nicolaiarocci added this to the 0.8.1 milestone May 28, 2018

@nicolaiarocci

This comment has been minimized.

Sign in to view
Member

nicolaiarocci commented May 28, 2018

We might also want to hold until Black reaches beta. Should not take too long.
@nicolaiarocci

This comment has been minimized.

Sign in to view
Member

nicolaiarocci commented May 29, 2018 •
edited

Black is now in beta: https://twitter.com/llanga/status/1001411218987302912

@nicolaiarocci nicolaiarocci changed the title from Consider adopting Black-style code formatting (and tooling) to Consider the adoption Black-style code formatting and tooling May 29, 2018

@nicolaiarocci nicolaiarocci changed the title from Consider the adoption Black-style code formatting and tooling to Consider the adoption of Black-style code formatting and tooling May 29, 2018

nicolaiarocci added a commit that referenced this issue May 29, 2018

@nicolaiarocci
Support pre-commit and tox linting 
- If pre-commit is installed, linting is performed on every commit. This
linting check and fixes are only applied to stage files.
- 'tox -e linting' will perform linting checks and fixes on all files in
the repository

Closes #1155.
8afae63

nicolaiarocci added a commit that referenced this issue May 30, 2018

@nicolaiarocci
Support pre-commit and tox linting 
- If pre-commit is installed linting is performed on every commit.
Linting checks and fixes are only applied to staged files.

- 'tox -e linting' will perform linting checks and fixes on all files in
the repository

Closes #1155.
63b60de

nicolaiarocci added a commit that referenced this issue May 30, 2018

@nicolaiarocci
Changelog update for #1155, #1156, #1157
Loading status checks…
f0bd841

@nicolaiarocci nicolaiarocci closed this in 6398aba May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment