Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft delete removes auth_field from document #1188

Closed
gwainer opened this issue Sep 5, 2018 · 3 comments
Closed

Soft delete removes auth_field from document #1188

gwainer opened this issue Sep 5, 2018 · 3 comments
Labels
Milestone

Comments

@gwainer
Copy link

@gwainer gwainer commented Sep 5, 2018

Expected Behavior

When using soft delete, the deleted document should remain with auth_field after deleted. I've tested using eve 0.7 and this is true, but I've noticed using eve 0.8 that with soft delete enabled, when a document is deleted, its auth_field is removed.

I see here, inside eve's deleteitem function, the document is retrieved from database with force_auth_field_projection with default value False, and then here this document without auth_field replaces the original.

That's undesired in my case because I need to keep the deleted documents belonging to the user that owns it. So later when getting the deleted documents I can bring the ones he deleted, and losing the auth_field this is not possible, the document ends ups inaccessible since it has no auth_field but the schema uses it.

Environment

  • Python version: 3.5.1
  • Eve version: 0.8

Thanks,

@nicolaiarocci nicolaiarocci added this to the 0.8.2 milestone Oct 3, 2018
@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Mar 27, 2019

it took a while, but it should be fixed now.

@gwainer
Copy link
Author

@gwainer gwainer commented Mar 27, 2019

Thank you! Any idea when 0.8.2 will be released?

@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Mar 28, 2019

Targeting next month!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants