Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expecting JSON response for rate limit exceeded scenario #1227

Closed
checkaayush opened this issue Jan 30, 2019 · 3 comments
Closed

Expecting JSON response for rate limit exceeded scenario #1227

checkaayush opened this issue Jan 30, 2019 · 3 comments
Milestone

Comments

@checkaayush
Copy link
Contributor

@checkaayush checkaayush commented Jan 30, 2019

Expected Behavior

A JSON response should be returned:

{
  "_status": "ERR",
  "_error": {
    "code": 429,
    "message": "Rate Limit exceeded"
  }
}

Actual Behavior

Text message saying Rate limit exceeded is returned with the code 429.

Refer: https://github.com/pyeve/eve/blob/master/eve/methods/common.py#L312

Environment

  • Python version: 3.5.x
  • Eve version: 0.8.1
@checkaayush checkaayush changed the title Missing JSON response for rate limit exceeded (429) scenario Expecting JSON response for rate limit exceeded (429) scenario Jan 30, 2019
@checkaayush checkaayush changed the title Expecting JSON response for rate limit exceeded (429) scenario Expecting JSON response for rate limit exceeded scenario Jan 30, 2019
@checkaayush
Copy link
Contributor Author

@checkaayush checkaayush commented Jan 30, 2019

Would be happy to submit a PR if JSON response was the expected behavior. If not, is there any advantage in sending a text response instead?

@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Mar 14, 2019

Yes please, do submit a PR for this. I will gladly review it.

@checkaayush
Copy link
Contributor Author

@checkaayush checkaayush commented Mar 15, 2019

Here you go @nicolaiarocci #1236 :)

@nicolaiarocci nicolaiarocci added this to the 0.8.2 milestone Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants