-
-
Notifications
You must be signed in to change notification settings - Fork 744
Eve broken with werzeug >= 0.15.3 #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
wangsha
added a commit
to wangsha/eve
that referenced
this issue
May 16, 2019
issue fixes: pyeve#1267
Merged
They sure have been playing around a lot with that Unauthorized thing. 0.15.1 broke it, and now 0.15.3 does it again 😄 I have pinned Werkzeug to 0.15.3 for the time being. We'll see if their API stabilizes over time. |
jlane9
pushed a commit
to jlane9/mockerena
that referenced
this issue
Dec 11, 2019
Recent werkzeug updates are causing issues with Eve. pyeve/eve#1267
jlane9
pushed a commit
to FanThreeSixty/mockerena
that referenced
this issue
Dec 11, 2019
Recent werkzeug updates are causing issues with Eve. pyeve/eve#1267
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I actually realized of this when tests failed from a PR i was preparing, and then tests on travis also failed. After some debugging i tracked down the error to werkzeug, and to this particular change referenced in this issue
pallets/werkzeug#1516
pallets/werkzeug@4ee2464
If i understant correctly, they are fixing something that was not right, but it breaks the expected value format of exceptions www_authenticate parameter here:
https://github.com/pyeve/eve/blob/master/eve/endpoints.py#L173:L174
were eve was expecting a
(None,)
when now it's simplyNone
.I'm not sure if this should be considered something wrong on werkzeug's side for changing that behavoir and file a bug there, or fix such assumption in eve.
What do you think?
Expected Behavior
Test pass in any environment
Actual Behavior
Auth tests fail when using werkzeug >=0.15.3
Environment
The text was updated successfully, but these errors were encountered: