Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Flask 2.2 #1485

Open
nicolaiarocci opened this issue Sep 3, 2022 · 2 comments
Open

Tests fail with Flask 2.2 #1485

nicolaiarocci opened this issue Sep 3, 2022 · 2 comments

Comments

@nicolaiarocci
Copy link
Member

nicolaiarocci commented Sep 3, 2022

Since Flask 2.2, all tests relying on app.add_url_rule are failing. Flask changelogfor v2.2 reports significant changes.

For the time being, I'm pinning Flask dependency to <2.2.

Anybody willing to take up this task?

@Kludex Kludex mentioned this issue Oct 12, 2022
@Kludex
Copy link
Contributor

Kludex commented Oct 12, 2022

The problem is that the setUp of TestBase uses the test_client, and then after, we modify the application.

A possible solution would be to remove the logic that makes those calls on the setUp, and then call those manually when needed per test basis. Can I proceed with this?

@nicolaiarocci
Copy link
Member Author

yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants