Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cerberus 1.0 Support #776

Closed
nckpark opened this issue Dec 2, 2015 · 6 comments
Closed

Cerberus 1.0 Support #776

nckpark opened this issue Dec 2, 2015 · 6 comments
Labels
Milestone

Comments

@nckpark
Copy link
Contributor

@nckpark nckpark commented Dec 2, 2015

This issue is a bit premature as Cerberus 0.10 has yet to be released, but I'm curious what the plan is for updating Eve to use it? Is there any timeline in mind? I'm eager to see the impact on validation performance - it seems like there could be some significant improvements in the new code.

@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Dec 3, 2015

I plan on supporting Cerberus 0.10 because it is better on all accounts. I have been hesitant however since it breaks backward compatibility in a big way so it is going to require a bit of work and, worse, will probably break most custom validators, making the upgrade to next Eve release a pain point.

I did not have the time to experiment with the update though so please feel free to play with it and submit a PR, if you feel like doing it.

@nicolaiarocci nicolaiarocci added this to the 0.7 milestone Dec 3, 2015
@nicolaiarocci nicolaiarocci changed the title Cerberus 0.10 Support Cerberus 1.0 Support May 9, 2016
@jim-bo
Copy link

@jim-bo jim-bo commented Jun 24, 2016

I would like to second the request for 1.0 support. I think the advances in Cerberus 1.x would be great to have in Python-Eve. In my case the recursive schema definitions is needed.

@dkellner
Copy link
Contributor

@dkellner dkellner commented Sep 14, 2016

I've started playing with this. It will probably take some time, though. I am planning to post an update on this within one or two weeks.

@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Sep 14, 2016

@dkellner excellent!

@nicolaiarocci nicolaiarocci modified the milestones: 0.7, 0.8 Oct 17, 2016
@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Mar 21, 2017

See #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.