Support partial request for media resource #1050
Closed
Conversation
|
@nicolaiarocci: what do you think? Personally I do not see test coverage... |
|
Hello and thanks for this. It is indeed a very cool feature. However, it would also need test coverage. |
eve/endpoints.py
Outdated
| if g[0]: | ||
| byte1 = int(g[0]) | ||
| if g[1]: | ||
| byte2 = int(g[1]) |
peterdemin
Aug 30, 2017
g[1] might be empty string, which will break int(''):
>>> int('')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: ''
g[1] might be empty string, which will break int(''):
>>> int('')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: ''
marschhuynh
Aug 30, 2017
Author
Contributor
@nicolaiarocci Yes, I will update the test as soon as possible.
@peterdemin Thank you for correcting me.
@nicolaiarocci Yes, I will update the test as soon as possible.
@peterdemin Thank you for correcting me.
|
This is still waiting on proper test coverage. Are you still planning to add it? |
|
Thanks for the commit update. I really want to merge this but I can't in its current state. Still waiting for test coverage. |
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
nicolaiarocci
added a commit
that referenced
this pull request
Apr 5, 2018
|
Refactored, rebased, test-covered, and finally merged. See 9ee2b5b |
lexhung
added a commit
to lexhung/eve
that referenced
this pull request
Dec 12, 2018
* upstream/master: (32 commits) Get rid of unwanted .vscode folder Add support for mongo $box geo query operator Marsch Huynh Improve partial downloads documentation Changelog for pyeve#1050 Test coverage for pyeve#1050 A little refactoring (DRY). Addresses pyeve#1050. fix: media endpoint Support partial request for media resource Officially deprecate Python 2.6 Changelog for pyeve#1130 Reduced error description details Fix PUT behavior with User-Restricted Resource Access flake8 typo Hung Le Changelog for pyeve#1095. Regression test for PR pyeve#1095. Oplog skipped even if confg.OPLOG=True DHuan ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I am creating an API for record and playback audio. I use Eve as a main lib for my project.
Without partial request, my player in my phone (iPhone) can not work.
So I change a little code to make Eve support partial request for the media resource.
Hope that makes sense.
Thanks.