New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use OrderedDict from backport_collections #1070

Merged
merged 1 commit into from Oct 15, 2017

Conversation

Projects
None yet
2 participants
@carlwgeorge
Contributor

carlwgeorge commented Oct 10, 2017

It is unnecessary to require the ordereddict module because the backport_collections module already has the OrderedDict class. This change removes the ordereddict dependency, and also ensures that backport_collections is only required when needed.

use OrderedDict from backport_collections
It is unnecessary to require the ordereddict module because the
backport_collections module already has the OrderedDict class.  This
change removes the ordereddict dependency, and also ensures that
backport_collections is only required when needed.

@nicolaiarocci nicolaiarocci merged commit fa8da19 into pyeve:master Oct 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

nicolaiarocci added a commit that referenced this pull request Oct 15, 2017

@nicolaiarocci

This comment has been minimized.

Member

nicolaiarocci commented Oct 15, 2017

Thanks!

@nicolaiarocci nicolaiarocci added this to the 0.8 milestone Oct 15, 2017

@carlwgeorge carlwgeorge deleted the carlwgeorge:ordereddict_cleanup branch Oct 15, 2017

lexhung added a commit to lexhung/eve that referenced this pull request Nov 1, 2017

Merge branch 'master' of https://github.com/pyeve/eve into oplog_bug
* 'master' of https://github.com/pyeve/eve: (374 commits)
  Changelog for pyeve#1070
  use OrderedDict from backport_collections
  Minor changelog fixes for pyeve#1048
  Support Decimal type MongoDB
  Changelog: add reference to proper PR
  Changelog update for pyeve#1042
  Fix a serialization bug that randomly skips fields if "x_of" is encountered
  Amedeo Bussi
  Changelog for pyeve#1030
  pep/flake, and remove duplicate test
  documentation improvements and fixes
  Bulk delete
  MONGO_DBNAME can be now used along with MONGO_URI
  Vasilis Lolis
  typo
  Amedeo91
  Changelog for pyeve#1031
  Bulk Embedded document resolution
  Delete unnecessary code
  Fix insidious bug in tests.TestPost class
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment