Move sort and where to functions - #1194
Closed
jsolbrig wants to merge 2 commits into
Closed
Conversation
their own functions for reuse.
Moved new functions inside Mongo class to allow them to access class attributes.
nicolaiarocci
added a commit
that referenced
this pull request
Jan 26, 2019
Member
|
Rebased and merged, see 7ddd46a PS: I am terribly sorry for the long wait. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make the parsing of
req.sortandreq.whereeasily reusable to support addition ofwherefunctionality to DELETE and PATCH requests on resource endpoints. These updates will be provided in subsequent pull requests.Changes
These changes simply copy functionality for parsing
req.sortandreq.wherefromMongo.find()to two new methods:Mongo._convert_sort_request_to_dict()andMongo._convert_where_request_to_dict().The new functions are exact copies of the code that had been in
Mongo.find()and introduce no new code.Tests
No new code has been added, code has only been moved. No new tests are required and all tests pass for Python 2.7.15, 3.4.6, 3.5.6, 3.6.6, and Pypy with the exception of the test referenced in #1193.