Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for data relation hateoas #1186 #1204

Closed
wants to merge 5 commits into from
Closed

Enhancement for data relation hateoas #1186 #1204

wants to merge 5 commits into from

Conversation

@smeng9
Copy link
Contributor

@smeng9 smeng9 commented Oct 12, 2018

Changes:

  1. Supports returning optional hateoas for fields with data relation,
    allowing the user to navigate to different resource and item endpoints.
    Now the returned "_links'' dictionary may have a "related'' dictionary inside
    and each key-value pair yields the related links for a data relation field.

  2. Updates XML renderer which now supports data field tag
    attributes such as "href" and "title"
    data field tags with data relation may be rendered as (according to #1186):

  3. Makes some minor changes on functions field_definition and resource_link
    when retrieving fields and resources to support this enhancement.

  4. Updates documentation that "related" hateoas items will only be included when appropriate.

  5. Includes tests for this feature and XML renderer.

Copy link
Member

@nicolaiarocci nicolaiarocci left a comment

Excellent

@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Oct 12, 2018

For reference, see #1186

Shaoyu added 2 commits Oct 12, 2018
@smeng9 smeng9 changed the title [WIP] Enhancement hateoas #1186 Enhancement for data relation hateoas #1186 Oct 15, 2018
@nicolaiarocci nicolaiarocci added this to the 0.8.2 milestone Jan 24, 2019
@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Jan 27, 2019

Rebased and merged. Thanks.

PS: sorry for the long wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants