Allow event fetched on diffs#475

[einarhuseby]

See PR #1223 for the other alternative introducing on_fetched_diffs.

This PR allows version=diffs to run when on_fetched* event hooks are wired up.

This makes all item and resource fetches fire the callback. A use case could be anonymizing documents via on_fetched_*. Accessing with version=diffs would expose the documents.

As discussed in #475 and inline code notes version=diffs will return partial documents which can have unexpected results if it's not handled correctly in the callback.

[einarhuseby]

Merged the changes as discussed in #1223 to this PR instead of making another PR since this is labelled for 0.8.2.

The callback now gets the entire list of diffs, which I think makes sense. Also updated the tests in TestCompleteVersioning; test_on_fetched_diffs and test_on_fetched_diffs_contacts.

Hateos _links seems to get an extra &version=diffs but I haven't looked further into that. Not sure if it's caused by this PR.

[nicolaiarocci]

Hateos _links seems to get an extra &version=diffs but I haven't looked further into that. Not sure if it's caused by this PR.

Can you please investigate further on this, and report back. Thanks.

[einarhuseby]

Looks like default_params is missing version

eve/eve/methods/get.py

Lines 622 to 634 in 7a8a6c2

	def _other_params(args):
	""" Returns a multidict of params that are not used internally by Eve.
	:param args: multidict containing the request parameters
	"""
	default_params = [
	config.QUERY_WHERE,
	config.QUERY_SORT,
	config.QUERY_PAGE,
	config.QUERY_MAX_RESULTS,
	config.QUERY_EMBEDDED,
	config.QUERY_PROJECTION,
	]

and then it gets added as other_params in

eve/eve/utils.py

Line 296 in 7a8a6c2

other_params_part = "".join(

Only observed for _links['self']['href']

Also, maybe QUERY_VERSION instead of VERSION_PARAM would make sense?

[nicolaiarocci]

rebased and merged, thank you