Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documents being mutated while computing etag with ignore_fields settings #1266

Closed
wants to merge 1 commit into from

Conversation

@sunbit
Copy link
Contributor

@sunbit sunbit commented May 15, 2019

As copy was used instead of deepcopy, if the ignore_fields setting contains a field that's nested inside others, the function mutated the original while discarding fields to compute the etag as asked.

@sunbit
Copy link
Contributor Author

@sunbit sunbit commented May 15, 2019

The travis checks are failing due to this issue already reported here:

#1267

nicolaiarocci added a commit that referenced this issue May 16, 2019
@nicolaiarocci nicolaiarocci added this to the 1.3.2 milestone May 16, 2019
@nicolaiarocci nicolaiarocci removed this from the 1.3.2 milestone May 16, 2019
@nicolaiarocci nicolaiarocci added this to the 0.9.1 milestone May 16, 2019
@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented May 16, 2019

rebased and merged. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants