Fix documents being mutated while computing etag with ignore_fields settings #1266
Conversation
|
The travis checks are failing due to this issue already reported here: |
|
rebased and merged. thanks. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As copy was used instead of deepcopy, if the ignore_fields setting contains a field that's nested inside others, the function mutated the original while discarding fields to compute the etag as asked.
The text was updated successfully, but these errors were encountered: