Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix documents being mutated while computing etag with ignore_fields settings #1266
Conversation
This comment has been minimized.
This comment has been minimized.
|
The travis checks are failing due to this issue already reported here: |
nicolaiarocci
added a commit
that referenced
this pull request
May 16, 2019
nicolaiarocci
modified the milestones:
1.3.2,
0.9.1
May 16, 2019
This comment has been minimized.
This comment has been minimized.
|
rebased and merged. thanks. |
nicolaiarocci
closed this
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sunbit commentedMay 15, 2019
As copy was used instead of deepcopy, if the ignore_fields setting contains a field that's nested inside others, the function mutated the original while discarding fields to compute the etag as asked.