Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor style improvements and 2 test fixes #1330

Merged
merged 3 commits into from Nov 29, 2019

Conversation

stefaang
Copy link
Contributor

@stefaang stefaang commented Nov 26, 2019

  • fixed the 401 or 405 assertion always returning True
  • tests were failing on a fresh install without test_user
  • I made it a bit more pythonic.

@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Nov 26, 2019

excellent. Tests are in dire need of refactoring (if not a complete rewrite).

@nicolaiarocci nicolaiarocci added this to the 0.10 milestone Nov 26, 2019
nicolaiarocci added a commit that referenced this issue Nov 29, 2019
@nicolaiarocci nicolaiarocci merged commit 8816e2c into pyeve:master Nov 29, 2019
1 check passed
@nicolaiarocci
Copy link
Member

@nicolaiarocci nicolaiarocci commented Nov 29, 2019

Thanks.

@@ -184,7 +183,7 @@ def prune_aggregation_stage(d):
abort(400, description="Aggregation query could not be parsed.")

for key, value in query.items():
if key[0] != "$":
if key.startswith("$"):
Copy link
Contributor

@mic-max mic-max Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intended or should it be if not key.startswith("$"):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not intended.

Copy link
Contributor

@mic-max mic-max Apr 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this code path isn't being tested?

Copy link
Member

@nicolaiarocci nicolaiarocci Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @mic-max. Feel free to PR a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants