Some minor style improvements and 2 test fixes - #1330
Merged
Merged
Conversation
stefaang
commented
Nov 26, 2019
stefaang
commented
Contributor
- fixed the 401 or 405 assertion always returning True
- tests were failing on a fresh install without test_user
- I made it a bit more pythonic.
Member
|
excellent. Tests are in dire need of refactoring (if not a complete rewrite). |
Member
|
Thanks. |
mic-max
reviewed
Apr 2, 2020
|
|
||
| for key, value in query.items(): | ||
| if key[0] != "$": | ||
| if key.startswith("$"): |
Contributor
There was a problem hiding this comment.
Was this change intended or should it be if not key.startswith("$"):
Contributor
There was a problem hiding this comment.
I guess this code path isn't being tested?
Member
There was a problem hiding this comment.
Thanks for the review @mic-max. Feel free to PR a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.