Expose media endpoint only if RETURN_MEDIA_AS_URL is True #1415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation
RETURN_MEDIA_AS_URL
behaves as follows:However, this is not entirely correct. Serving media files at a dedicated media endpoint is, in the current version of Eve, enabled regardless of what the value of
RETURN_MEDIA_AS_URL
is. This poses a serious security risk as most users that useRETURN_MEDIA_AS_BASE64_STRING = True
won't be aware that their files can be served publicly via a url even if they explicitly setRETURN_MEDIA_AS_URL
toFalse
(it's False by default).This change simply makes sure the media endpoint is enabled only if
RETURN_MEDIA_AS_URL
isTrue
.Side note: Current version of Eve does though allow us to disable the media endpoint by setting
MEDIA_ENDPOINT
toFalse
, but this is an undocumented feature and users can only be made aware of it by browsing through this source code here. In order not to introduce too many breaking changes I decided to keep this code as is as it's unlikely to cause harm.