New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to use a different authorization database. #642

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@davidtwco
Contributor

davidtwco commented Jun 1, 2015

Hi,

I added a new configuration value, MONGO_AUTHDBNAME, that is passed to PyMongo's authenticate function and should allow for authentication on databases different from the main database that's used for the data storage.

I've added it to the documentation, but unfortunately was unable to find where it should be included in the tests, however, all the tests that are existing, run fine with no issues. I'd appreciate some pointers to where tests should be included for this.

@nicolaiarocci

This comment has been minimized.

Show comment
Hide comment
@nicolaiarocci

nicolaiarocci Jun 2, 2015

Member

Hello and thanks for your contribution.

Delegated Authentication was introduced in MongoDB 2.4 and removed on 2.6. With the advent of MongoDB 3.0 I wonder if we want to add support for this feature, given that it has been abandoned for a while.

Thoughts?

Member

nicolaiarocci commented Jun 2, 2015

Hello and thanks for your contribution.

Delegated Authentication was introduced in MongoDB 2.4 and removed on 2.6. With the advent of MongoDB 3.0 I wonder if we want to add support for this feature, given that it has been abandoned for a while.

Thoughts?

@davidtwco

This comment has been minimized.

Show comment
Hide comment
@davidtwco

davidtwco Jun 2, 2015

Contributor

Hi,

I never noticed that feature had been removed.

I made this change because I had been creating a docker image for an API using Eve, and was attempting to link it with the tutum/mongodb image by the folks over at tutum.co. I was getting an authentication error, when I asked the developers behind the tutum/mongodb image I was informed that I'd have to authenticate against the admin database first.

After some research, I made this change to allow for alternate authentication databases, however, I might be referring to the wrong feature when I mention Delegated Authentication - because I'm certain that the database image I'm using is version 3.0 of MongoDB, and requires me to auth on a different database. I wonder if this mongo shell parameter refers to the removed Delegated Authentication feature or something else?

Edit: Fixed shell parameter link.

Contributor

davidtwco commented Jun 2, 2015

Hi,

I never noticed that feature had been removed.

I made this change because I had been creating a docker image for an API using Eve, and was attempting to link it with the tutum/mongodb image by the folks over at tutum.co. I was getting an authentication error, when I asked the developers behind the tutum/mongodb image I was informed that I'd have to authenticate against the admin database first.

After some research, I made this change to allow for alternate authentication databases, however, I might be referring to the wrong feature when I mention Delegated Authentication - because I'm certain that the database image I'm using is version 3.0 of MongoDB, and requires me to auth on a different database. I wonder if this mongo shell parameter refers to the removed Delegated Authentication feature or something else?

Edit: Fixed shell parameter link.

@nicolaiarocci

This comment has been minimized.

Show comment
Hide comment
@nicolaiarocci

nicolaiarocci Jun 2, 2015

Member

That link is about mongorestore but yes, even the Mongo 3.0 docs don't mention the feature as being deprecated/retired since 2.6. Also, PyMongo changelog does not seem to report any significant change to authentication delegation since PyMongo 2.5 which introduced it.

Let's assume that's an error in PyMongo documentation. When I get back I will see if I can somehow add a test for this. Stay tuned.

Member

nicolaiarocci commented Jun 2, 2015

That link is about mongorestore but yes, even the Mongo 3.0 docs don't mention the feature as being deprecated/retired since 2.6. Also, PyMongo changelog does not seem to report any significant change to authentication delegation since PyMongo 2.5 which introduced it.

Let's assume that's an error in PyMongo documentation. When I get back I will see if I can somehow add a test for this. Stay tuned.

@davidtwco

This comment has been minimized.

Show comment
Hide comment
@davidtwco

davidtwco Jun 18, 2015

Contributor

Hi,

Any update on this?

Contributor

davidtwco commented Jun 18, 2015

Hi,

Any update on this?

nicolaiarocci added a commit that referenced this pull request Jun 19, 2015

@nicolaiarocci

This comment has been minimized.

Show comment
Hide comment
@nicolaiarocci

nicolaiarocci Jun 19, 2015

Member

Merged with nicolaiarocci@235c66f

Thanks!

Member

nicolaiarocci commented Jun 19, 2015

Merged with nicolaiarocci@235c66f

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment