New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcelRequest get_file_tuple get the extension error #15

Closed
banxi1988 opened this Issue Aug 18, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@banxi1988
Copy link

banxi1988 commented Aug 18, 2016

the below line
extension = filename.split(".")[1]
should use the rsplit('.',1) in case of file name has more than one dot

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Aug 19, 2016

truly valid comment. will fix it.

@chfw chfw added the enhancement label Aug 19, 2016

chfw added a commit that referenced this issue Aug 21, 2016

chfw added a commit that referenced this issue Aug 21, 2016

chfw added a commit that referenced this issue Aug 21, 2016

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Aug 21, 2016

released the fix in v0.0.5

@chfw chfw closed this Aug 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment