New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to unicode file name #22

Merged
merged 6 commits into from Jun 22, 2017

Conversation

Projects
None yet
3 participants
@howl-anderson
Copy link
Contributor

howl-anderson commented Jun 21, 2017

No description provided.

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Jun 21, 2017

Your PR is welcome. Would you like to go an extra mile, to include a test case for your change as well?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #22 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   98.54%   98.67%   +0.13%     
==========================================
  Files           7        7              
  Lines         274      302      +28     
==========================================
+ Hits          270      298      +28     
  Misses          4        4
Impacted Files Coverage Δ
flask_excel/__init__.py 100% <100%> (ø) ⬆️
tests/test_upload_n_download_excel.py 98.36% <100%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d67cc...7ce635f. Read the comment docs.

@howl-anderson

This comment has been minimized.

Copy link
Contributor Author

howl-anderson commented Jun 21, 2017

I have updated test case and add a demo to tiny_example.py. If there is something else that needs I do, please tell me. I am very pleased to contribute.

@@ -34,6 +35,18 @@ def export_records():
file_name="export_data")


@app.route("/download_unicode_file_name_utf8", methods=['GET'])

This comment has been minimized.

@chfw

chfw Jun 21, 2017

Member

I see that you would like to show both str and unicode are handled with your change. However, I would suggest let's keep one of the two demo functions.

@@ -71,8 +76,11 @@ def test_no_file_type(self):
def test_override_file_name(self):
for file_type in FILE_TYPE_MIME_TABLE.keys():
file_name = 'override_file_name'
url_encoded_file_name = quote(file_name)

This comment has been minimized.

@chfw

chfw Jun 21, 2017

Member

As you have tried to demonstrate in the tiny_example.py, could you please invest a bit more effort in writing two additional test case for the previous two demo functions.

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Jun 21, 2017

It looks good so far. Please see my comments.

In terms of release, I think I will quickly get it out of the door if all required is done.

@chfw

chfw approved these changes Jun 22, 2017

@chfw chfw merged commit 8c76994 into pyexcel-webwares:master Jun 22, 2017

3 checks passed

codecov/patch 100% of diff hit (target 98.54%)
Details
codecov/project 98.67% (+0.13%) compared to e1d67cc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@howl-anderson

This comment has been minimized.

Copy link
Contributor Author

howl-anderson commented Jun 22, 2017

WOW! Thank you! If there are something need improved, please let me know.

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Jun 22, 2017

It will be released under New BSD license and your change will be migrated to its siblings: django-excel and pyramid-excel. Are you happy with what will happen next?

chfw added a commit that referenced this pull request Jun 22, 2017

additional arrangement for #22: 1. increment the version, 2. update c…
…opyright so that at least contributor had a share of the copyright under new bsd.

chfw added a commit that referenced this pull request Jun 22, 2017

chfw added a commit that referenced this pull request Jun 22, 2017

@howl-anderson

This comment has been minimized.

Copy link
Contributor Author

howl-anderson commented Jun 22, 2017

It's a pleasure to see my code can serve so many great projects. I am very happy with that.

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Jun 22, 2017

That's what I'd like to hear. Thanks. The release will follow.

@chfw

This comment has been minimized.

Copy link
Member

chfw commented Jun 22, 2017

published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment