Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExcelRequest get_file_tuple get the extension error #15

Closed
codetalks-new opened this issue Aug 18, 2016 · 2 comments
Closed

ExcelRequest get_file_tuple get the extension error #15

codetalks-new opened this issue Aug 18, 2016 · 2 comments
Labels
enhancement

Comments

@codetalks-new
Copy link

codetalks-new commented Aug 18, 2016 •
edited

the below line
extension = filename.split(".")[1]
should use the rsplit('.',1) in case of file name has more than one dot
@chfw
Copy link
Member

chfw commented Aug 19, 2016

truly valid comment. will fix it.

chfw added a commit that referenced this issue Aug 21, 2016
@chfw
address issue #15: file name could have many dots
e495309
chfw added a commit that referenced this issue Aug 21, 2016
@chfw
test issue #15
0d7449d
chfw added a commit that referenced this issue Aug 21, 2016
@chfw
test #15: throw exception if not dot found in the file name
1344d31
@chfw
Copy link
Member

chfw commented Aug 21, 2016

released the fix in v0.0.5

@chfw chfw closed this as completed Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codetalks-new @chfw