Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Expose control over Django bulk_save option #46
I'm running into an issue with Django's QuerySet.bulk_create() on multi-table inheritance which might be addressed in some cases. The use of this feature is controlled using the bulk_save option on pyexcel_io.database.importers.django.DjangoModelWriter...however, this is not exposed by pyexcel_io.database.importers.django.DjangoBookWriter:
A simple patch to address this would be to change that to:
or (unless there is some reason to limit what is passed?) possibly even:
Higher up, the ability to specify bulk_save is present in pyexcel.internal.core.save_sheet and save_book but is not exposed by pyexcel.internal.meta.BookMeta.save_to_django_models. This would need to be trivially addressed too.
FWIW, I'm presently using pyexcel-io 0.5.4, but I see that master (as above) also currently has this issue.
Thanks. See my comment on the commit.…
On 10 Jan 2018 17:07, "jaska" ***@***.***> wrote: I am sorry for the delay. Please try it. I have chosen the first suggestion. Will release it soon. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEp7KeLqLohpxu1UUUkpm00BTgvBfjlCks5tJO4rgaJpZM4ROJs4> .